microsoft / microsoft/playwright-dotnet
[Feature] Allow async predicates for RunAndWaitFor methods
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 3k
- Forks
- 304
- Avg merge
- 20h 47m
- Merged PRs (30d)
- 6
Description
Given RequestFinished events already contain Response object it would be more flexible for the Predicate<T> that is passed by options of RunAndWaitForRequestFinished (and WaitForRequestFinished) methods to use the IReponse object instead of IRequest.
I can make the changes in code-base but I'd like to discuss architecture here - before committing to these changes.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the RunAndWaitForRequestFinished and WaitForRequestFinished methods and their predicate options. Clarify whether the intended change is asynchronous predicates, predicates over IResponse instead of IRequest, or both, then resolve the API design before identifying implementation files and tests. Done should include an agreed architecture and corresponding coverage.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- testing-qa
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100