microsoft / microsoft/picologging
Logger doesn't support weak reference
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 779
- Forks
- 29
- Avg merge
- 23h 3m
- Merged PRs (30d)
- 1
Description
CPython Logger supports weak reference, picologging Logger does not.
Supporting weakreference is fairly straightforward:
https://docs.python.org/3.10/extending/newtypes.html#weak-reference-support
I tested that change locally and it works. I haven't been able to ascertain how much of a performance hit it is (if any), however. Let me know what you think and whether you'd like a PR.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Logger implementation and the linked CPython weak-reference support documentation. Determine where weak-reference support belongs and check whether it affects performance, then verify that Logger instances can be weakly referenced and compare the relevant behavior with CPython's Logger.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100