microsoft / microsoft/perfview
Disable DiagnosticSource event source and ASP.NET Core event source by default
Open
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 4.7k
- Forks
- 775
- Avg merge
- 5d 11h
- Merged PRs (30d)
- 9
Description
Today perfview turns on diagnostic source events and deprecated ASP.NET Core events:
The ASP.NET Core events should be removed. I think the diagnostic source event source should be configurable but off by default as well.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read the referenced section of src/PerfView/CommandProcessor.cs at lines 742-761 to understand how diagnostic source and ASP.NET Core event sources are enabled. Done means removing the deprecated ASP.NET Core events and making diagnostic source events configurable while leaving them disabled by default.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- devtools, observability-sre
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100