microsoft / microsoft/perfview
Freeze processing in EventPipeEventSource if uncaught exception is thrown in callback.
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 4.7k
- Forks
- 775
- Avg merge
- 5d 11h
- Merged PRs (30d)
- 9
Description
Environment
- Microsoft.Diagnostics.Tracing.TraceEvent: 2.0.61
- Microsoft.Diagnostics.NETCore.Client: 0.2.141901
- EventPipe sender app and receiver app's TFM: net5.0-rc2
Steps to reproduce
- run app which produce EventSource event periodically
- start EventPipe session by DiagnosticClient
- create EventPipeEventSource from event stream
- set callback to DynamicEventParser.All
- Exception will be thrown in callback
- start processing
full test code is uploaded to gist
Expected result
callback is invoked periodicaly, or at least terminate event processing when EventPipeEventSource.StopProcessing is called.
Actual result
callback was never invoked again, and EventPipeEventSource.Process never returned, even if EventPipeEventSource.StopProcessing was called.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with EventPipeEventSource.Process and the callback assigned through DynamicEventParser.All, then compare the reproduction in the linked gist with the StopProcessing behavior described here. Done means event processing no longer remains blocked after the callback throws and StopProcessing can terminate processing as expected.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- devtools, performance
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100