microsoft / microsoft/perfview
TMF file parsing
Open
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 4.7k
- Forks
- 775
- Avg merge
- 5d 11h
- Merged PRs (30d)
- 9
Description
I figured out the TMF file parsing is overly simplified and doesn't support some more complex structures used for example in MSDTC (C:\WINDOWS\system32\MsDtc\Trace\msdtctr.mof). The parser understand only one #typev per file, but there were still issues loading this TMF with the parser:
- datetime type was not supported
- parsing regular expressions were very strict with respect to whitespace and naming
- system attributes (
%1-%9) were not supported - multiple
typevs per structure was not supported
I am attaching proposed fix in this branch.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the linked msdtc-mof comparison branch first, then locate PerfView’s TMF parser and any relevant tests; the issue names no files or tests. Done means handling datetime types, flexible whitespace and naming, system attributes, and multiple typev entries per structure.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100