microsoft / microsoft/perfview
DynamicTraceEventParser does NOT support field type "win:SID"
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 4.7k
- Forks
- 775
- Avg merge
- 5d 11h
- Merged PRs (30d)
- 9
Description
In Windows 10 Update 1903, the "Microsoft-Windows-Kernel-Process" manifest was updated, and a new type "win:SID" was introduced.
This type is of variable length, it is a simple security identifier.
ProviderManifest.GetTypeForManifestTypeName returns null for "win:SID", and thus the parser doesn't parse anything after that field (so it misses the most important "ImageName" field).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with ProviderManifest.GetTypeForManifestTypeName and the DynamicTraceEventParser path that handles manifest fields. Trace how an unknown win:SID field prevents subsequent fields from being parsed. Done means win:SID is recognized as a variable-length security identifier and parsing reaches the later ImageName field.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- devtools, operating-systems, performance
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100