microsoft / microsoft/pai

Better to use docker log time as fluentd record time in DB table?

Open
#4,927 0 comments 0 reactions 1 assignee View on GitHub

@hzy46 is already working on this.

Since Sep 22, 2020.

pai-dev
Dominant language
JavaScript
Stars
2.7k
Forks
554
Avg merge
20h 42m
Merged PRs (30d)
14

Description

Current DB record time is from fluentd: https://github.com/microsoft/pai/blob/3de6ad16b14ef8429f72eea1872e4de9498bab3e/src/fluentd/src/fluent-plugin-pgjson/lib/fluent/plugin/out_pgjson.rb#L208

For more precise, we can use the docker log time, i.e. the below collectTime

    # FC Docker Container Log:
    # {"log":"I1024 12:14:54.903623      11 controller.go:1382] [default/efkt168][worker][0]: syncTaskState: Task will be retried: ObjectSnapshot: {\"kind\":\"Framework\"}\n",
    # "stream":"stderr",
    # "time":"2019-10-24T12:14:54.9037283Z"}

    # Add collectTime
    <filter fc-objectsnapshots>
      @type record_transformer
      enable_ruby true
      <record>
        collectTime ${record['time']}
      </record>
    </filter>


Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.