Use originalUserExitCode to judge if PAIRuntimeExitAbnormall(256) exitcode
@Binyang2014 is already working on this.
Since Jul 1, 2020.
- Dominant language
- JavaScript
- Stars
- 2.7k
- Forks
- 554
- Avg merge
- 20h 42m
- Merged PRs (30d)
- 14
Description
Why is this needed:
Container may also be killed with exitcode 255 (not normal signal), conflicts with PAIRuntimeUnknownFailed(255) https://github.com/microsoft/pai/blob/4417236c9f8b885038e7118676622fe6ea243cb1/src/k8s-job-exit-spec/config/k8s-job-exit-spec.yaml#L1197-L1198
To better avoid conflicts, check if originalUserExitCode appeared in diagnosic
if yes, current behaiour,
otherwise, it is not returned by runtime, check if the exicode is in spec and it is NOT owned (issuer) by runtime,
if yes, return the spec entry (such as SIGKILL entry),
otherwise, return PAIRuntimeExitAbnormall(256), https://github.com/microsoft/pai/blob/4417236c9f8b885038e7118676622fe6ea243cb1/src/k8s-job-exit-spec/config/k8s-job-exit-spec.yaml#L1246-L1247
@Binyang2014 to double check the design
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.