microsoft / microsoft/openvmm

fdt/builder: enforce BE datatypes on add_prop_array

Open
#777 0 comments 1 reaction 1 assignee View on GitHub

Nobody has claimed this yet.

enhancement good first issue
Dominant language
Rust
Stars
1.9k
Forks
238
Avg merge
1d 15h
Merged PRs (30d)
100

Description

add_prop_array doesn't have any checks that the data is Big Endian. FDT requires that data is BE. Current usage kind of gets away with it, as we pass empty ranges or just u8 unformed entropy data.

Perhaps we should use zerocopy BE byte types for add_prop_array and also perhaps prop_array_iter?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.