Deprecate and remove `UnderhillDiag` service
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 1.9k
- Forks
- 238
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 100
Description
The existing service cannot be extended due to #396. It's also named using the old codename. #397 adds a new service, OpenhclDiag.
To remove the old service, we need to add all the existing methods to the new service and update clients to try both. I think we could do this somewhat transparently via some "rename" functionality in the client and server packages, rather than have a bunch of custom code all over the place.
I'll open an issue.
Originally posted by @jstarks in https://github.com/microsoft/openvmm/pull/397#discussion_r1858987543
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare the existing UnderhillDiag service with the new OpenhclDiag service from #397, then inspect the client and server packages to understand their service discovery and method handling. The work is complete when the new service exposes all existing methods, clients can try both services transparently, and the old service can be removed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- api
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100