microsoft / microsoft/openvmm

dep-review workflow fails to request review: "Could not resolve" openvmm-dependency-reviewers team

Open
#3,471 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
1.9k
Forks
238
Avg merge
1d 15h
Merged PRs (30d)
100

Description

Summary

The Dependency Review workflow (.github/workflows/dep-review.yml) fails on every PR that introduces external Cargo dependency changes. The script in .github/scripts/dep-review.js calls pulls.requestReviewers for the team microsoft/openvmm-dependency-reviewers, and GitHub responds with a 422:

RequestError [HttpError]: Validation Failed: "Could not resolve to a node with the global id of 'T_kwDOAF3p4s4AqrNG'."
    at async run (/home/runner/work/openvmm/openvmm/.github/scripts/dep-review.js:338:5)

POST URL: https://api.github.com/repos/microsoft/openvmm/pulls/<n>/requested_reviewers
Body: {"team_reviewers":["openvmm-dependency-reviewers"]}

The unhandled error fails the workflow step and blocks the PR's required check.

Affected runs

Every recent failure of the Dependency Review workflow was hit by this. A few examples:

PRs without external dep changes pass because the team-request branch in the script is never reached.

Likely cause

The team slug openvmm-dependency-reviewers (under the microsoft org) is no longer resolvable by the workflow token \u2014 most likely the team was deleted, renamed, or had its repo access removed. A stale cached node ID (T_kwDOAF3p4s4AqrNG) shows up in the error message.

Suggested fix

One of:

  1. Recreate / restore access for the microsoft/openvmm-dependency-reviewers team.
  2. Update DEP_REVIEW_TEAM in .github/scripts/dep-review.js to a team that exists and is accessible to the workflow.
  3. Wrap the requestReviewers call in a try/catch so a missing team doesn't fail the check (and surfaces a warning instead).

Option 3 alone would unblock PRs immediately even if the team situation is still being sorted out.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with .github/workflows/dep-review.yml and .github/scripts/dep-review.js around line 338, then inspect DEP_REVIEW_TEAM and the linked failing workflow runs. Confirm how the reviewer-request path should behave when the team cannot be resolved; done means dependency-review PRs no longer fail solely because of this request and the intended reviewer handling is verified.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions, javascript
Domain
ci-cd, devops
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.