microsoft / microsoft/openvmm

Update coding guidelines on guest_arch

Open
#320 0 comments 0 reactions 1 assignee View on GitHub

@jstarks is already working on this.

Since Nov 13, 2024.

documentation
Dominant language
Rust
Stars
1.9k
Forks
238
Avg merge
1d 15h
Merged PRs (30d)
100

Description

That's a very insightful comment John, thank you. Thinking about it in terms of worker code vs. "client" code is not something I had considered, but makes a lot of sense.

Could you send a PR up which adds these thoughts to https://openvmm.dev/guide/dev_guide/contrib/code.html, so we can codify some of this thinking? Or, if you'd like to drive-by include it as part of this PR (which looks like it'll need at least one more revision anyways), that'd be great.

Originally posted by @daprilik in https://github.com/microsoft/openvmm/pull/307#discussion_r1841200830

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.