microsoft / microsoft/openvmm

remove usages of futures::select! in the repo with futures_concurrency

Open
#1,246 0 comments 1 reaction 1 assignee View on GitHub

Nobody has claimed this yet.

good first issue linting
Dominant language
Rust
Stars
1.9k
Forks
238
Avg merge
1d 15h
Merged PRs (30d)
100

Description

select! has subtle rules you need to get right, and we really would like to push people towards using things in futures_concurrency which are nicer to use.

We should remove the exiting usages in the repo and replace them, then disallow select! in clippy. Maybe a good first step is to disallow select! and require overriding for the existing usages so we can not mislead people into using select!

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.