microsoft / microsoft/onnxruntime

WinML tests have implicit dependency on `--enable_onnx_tests` being specified

Open
#7,857 1 comment 0 reactions 1 assignee View on GitHub

@ryanlai2 is already working on this.

Since Jun 15, 2021.

platform:windows
Dominant language
C++
Stars
21.9k
Forks
4.2k
Avg merge
4d 8h
Merged PRs (30d)
179

Description

Describe the bug
If --use_winml is specified when building ONNX Runtime but --enable_onnx_tests is not, the build will fail when it attempts to run the WinML unit tests due to setup_test_data not having been called to create the 'models' directory

https://github.com/microsoft/onnxruntime/blob/bed6e87cbdbe1120f7958b6e1eeff5eda3c11e8e/tools/ci_build/build.py#L2051-L2052

and the WinML test setup code throwing if that directory does not exist

https://github.com/microsoft/onnxruntime/blob/e344a583b0f39c6b8aca57f61b957022f45ec047/winml/test/model/model_tests.cpp#L151

Urgency
None.

System information

  • ONNX Runtime installed from (source or binary): source
  • ONNX Runtime version: master

Expected behavior
Implicit dependency should be enforced when validating build.py arguments, or removed if having a 'models' directory is not required. The calling code would suggest that a non-existent directory was permissible at some point.

https://github.com/microsoft/onnxruntime/blob/e344a583b0f39c6b8aca57f61b957022f45ec047/winml/test/model/model_tests.cpp#L175-L176

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.