microsoft / microsoft/onnxruntime
WinML tests have implicit dependency on `--enable_onnx_tests` being specified
@ryanlai2 is already working on this.
Since Jun 15, 2021.
- Dominant language
- C++
- Stars
- 21.9k
- Forks
- 4.2k
- Avg merge
- 4d 8h
- Merged PRs (30d)
- 179
Description
Describe the bug
If --use_winml is specified when building ONNX Runtime but --enable_onnx_tests is not, the build will fail when it attempts to run the WinML unit tests due to setup_test_data not having been called to create the 'models' directory
and the WinML test setup code throwing if that directory does not exist
Urgency
None.
System information
- ONNX Runtime installed from (source or binary): source
- ONNX Runtime version: master
Expected behavior
Implicit dependency should be enforced when validating build.py arguments, or removed if having a 'models' directory is not required. The calling code would suggest that a non-existent directory was permissible at some point.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.