microsoft / microsoft/onnxruntime
Possible reversed functions in winml compute shaders
Open
@zhangxiang1993 is already working on this.
Since Feb 4, 2021.
platform:windows
- Dominant language
- C++
- Stars
- 21.9k
- Forks
- 4.2k
- Avg merge
- 4d 11h
- Merged PRs (30d)
- 184
Description
**Describe the bug**
I was looking through the source of winml parts and noticed that in this shader [SurfaceToTensorFloat.hlsl](https://github.com/microsoft/onnxruntime/blob/master/winml/lib/Api.Image/shaders/SurfaceToTensorFloat.hlsl) the definitions of `SurfaceToTensorGRAY8 `and `SurfaceToTensorRGB8 `looks like they're reversed/swapped? GRAY8 version assigns 3 values per output and RGB8 assigns only one. Apologies in advance if I've missed something here and it's actually correct.
**Urgency**
None. I will not ultimately be using built-in tensorization.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.