microsoft / microsoft/onnxruntime
MIGraphX EP: `ORT_MIGRAPHX_INT8_CALIBRATION_TABLE_NAME` env variable seems do not work
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 21.9k
- Forks
- 4.2k
- Avg merge
- 4d 11h
- Merged PRs (30d)
- 184
Description
https://github.com/microsoft/onnxruntime/blob/7253fdc89684c5febfee901046e4aaefe79122c5/onnxruntime/core/providers/migraphx/migraphx_execution_provider.cc#L205-L214
As shown above, `int8_calibration_cache_available_` only depends on whether `info.int8_calibration_table_name` is empty. So, when `info` is not set, int8 quantization never works even if `ORT_MIGRAPHX_INT8_CALIBRATION_TABLE_NAME` is set.
Maybe replace line 213 with `int8_calibration_cache_available_ = !int8_calibration_table_name_.empty();` is better?
NOTE: Since https://github.com/microsoft/onnxruntime/commit/27f4dcd4a1860a52f1601b72f9c8a6767efebcf0.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at onnxruntime/core/providers/migraphx/migraphx_execution_provider.cc lines 205-214 and trace how the calibration table name is initialized from provider options and the environment variable. Reproduce the case where only ORT_MIGRAPHX_INT8_CALIBRATION_TABLE_NAME is set, then verify that INT8 calibration becomes available without explicit info; preserve the behavior noted in commit 27f4dcd4a1860a52f1601b72f9c8a6767efebcf0.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- machine-learning
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 74/100