microsoft / microsoft/onnxruntime

[Feature Request] why is `FunctionProto` missing from the file "onnxruntime/core/providers/shared_library/provider_wrappedtypes.h"?

Open
#20,836 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature request
Dominant language
C++
Stars
21.9k
Forks
4.2k
Avg merge
4d 11h
Merged PRs (30d)
184

Description

### Describe the feature request

Can you please share what you thought about not adding `FunctionProto` to the file "onnxruntime/core/providers/shared_library/provider_wrappedtypes.h"?
Thanks.

### Describe scenario use case

During the development of the "EP context" feature of a shared-lib EP, we need to convert an `IndexedSubGraph` to a `FunctionProto` to serialized the `IndexedSubGraph`, just as stated at https://github.com/microsoft/onnxruntime/blob/362a62390545234d28661307c7a203f2546280ae/include/onnxruntime/core/graph/indexed_sub_graph.h#L28-L39

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read onnxruntime/core/providers/shared_library/provider_wrappedtypes.h alongside include/onnxruntime/core/graph/indexed_sub_graph.h, especially the referenced lines, to understand the shared-library type surface and the requested serialization path. Done means resolving whether FunctionProto belongs in the wrapped types and validating the resulting EP-context use case.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend, machine-learning
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.