microsoft / microsoft/onnxruntime
[Feature Request] Incomplete implementation of RoiAlign
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 21.9k
- Forks
- 4.2k
- Avg merge
- 4d 11h
- Merged PRs (30d)
- 184
Description
### Describe the feature request
onnxruntime shows this message when `mode=="max"` for RoiAlign: `The existing summation for max mode and sampling ratios besides 1 is incorrect and will be fixed in the next ORT 1.13 release. Thus the results of RoiAlign will be different.`.
Is that expected?
### Describe scenario use case
See issue https://github.com/onnx/onnx/issues/4764.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the RoiAlign implementation and review the linked ONNX issue for the expected behavior. Investigate the warning for max mode with sampling ratios besides 1, and define completion as matching the expected ONNX behavior without the reported discrepancy.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- machine-learning
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100