microsoft / microsoft/onnxruntime-genai
More API parameters could be const
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 1.1k
- Forks
- 354
- Avg merge
- 2d 16h
- Merged PRs (30d)
- 85
Description
Assuming we're not going to modify the values in these inputs and they could be const.
OgaGeneratorParamsSetModelInput: `OgaTensor* tensor`
OgaGeneratorParamsSetWhisperInputFeatures: `OgaTensor* tensor`
OgaCreateTensorFromBuffer: `void* data`
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the declarations and definitions for OgaGeneratorParamsSetModelInput, OgaGeneratorParamsSetWhisperInputFeatures, and OgaCreateTensorFromBuffer. Check that these parameters are not modified, update their signatures to preserve const input data, and verify the project still builds successfully.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- api
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100