microsoft / microsoft/ntttcp-for-linux
set_socket_non_blocking() is commented out in udpstream.c
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 426
- Forks
- 108
- PR merge metrics
- No merged PRs in 30d
Description
In udpstream.c, the set_socket_non_blocking() call is commented out. Any reason why?
I thought non-blocking I/O is the only default I/O model implemented ntttcp-for-linux, and it is better for Tput performance (than blocking I/O). The tcp mode is still setting non-blocking socket mode.
Can we uncomment it?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading udpstream.c, focusing on the commented set_socket_non_blocking() call, and compare it with the TCP path where socket non-blocking mode remains enabled. Check the surrounding comments and existing benchmark behavior to determine whether enabling the call is safe; done means the intended UDP I/O mode is restored without regressing TCP or throughput behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c, linux
- Domain
- networking, performance
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100