microsoft / microsoft/ntttcp-for-linux

Compile error: parameter name omitted

Open
#101 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
426
Forks
108
PR merge metrics
No merged PRs in 30d

Description

Hi team.

I compile the project in fedora 42 with gcc 15.2 failed https://github.com/microsoft/ntttcp-for-linux/pull/97. But do well in ubuntu 24.04 with gcc 13.3.

I',m commit https://github.com/microsoft/ntttcp-for-linux/commit/e18597c05e3d4b439849ce0e149cb701ff5a36c2 recently, but the CI failed due to "parameter name omitted" in aarch64 ci. Upon checking some documentation, I found some issues that require your decision.

  1. use __attribute__((unused)) , but it depends compiler.
  2. use [[maybe_unused]] , but it depends c23.
  3. use (void) unused, but add extra code.

In my opinion, the third option is optimal. While it adds some extra code, it maintains full compatibility with different compilers and language versions. However, since this touches on coding style (specifically, the recommended practice of using macros for unused variables), the final decision should be left to your team's discretion.

Ok, I see fix approved https://github.com/microsoft/ntttcp-for-linux/pull/100 .

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing commit e18597c05e3d4b439849ce0e149cb701ff5a36c and the linked aarch64 CI failure to understand the omitted-parameter error. Check pull request #100 for the approved fix; the issue is done when the project compiles successfully across the affected compiler and CI configurations.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
build-system, networking
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
15/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.