microsoft / microsoft/nodejstools

Jade: Characters used by Angular 2 are not recognized as valid attribute names

Open
#844 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Jade up-for-grabs
Dominant language
C#
Stars
1.8k
Forks
355
PR merge metrics
No merged PRs in 30d

Description

It seems that Jade syntax hightlighting is buggy: It does not support characters like * or [] in an attribute name.
Unfortunately, Angular 2 relies heavily on them :(

I guess that JadeTokenizer.GetAttribute() method is to blame

image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in Nodejs/Product/Nodejs/Jade/Tokenizer/JadeTokenizer.cs, focusing on the GetAttribute() method identified in the issue. Reproduce the syntax-highlighting problem with Angular 2 attribute names containing * or [], then verify that those characters are recognized as valid attribute-name syntax.

Written by the indexing model from the issue text.

Assessment

Tech stack
angular, csharp
Domain
tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.