microsoft / microsoft/nodejstools

Exclude node_modules folder from test discovery/execution

Open
#2,156 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C#
Stars
1.8k
Forks
355
PR merge metrics
No merged PRs in 30d

Description

Currently tests discovery will go through the entire directory including node_modules to find tests. In most cases this is probably not the intended behavior that the user would expect. We should omit the node_modules directory for test discovery.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the test discovery and execution entry points in the Node.js Tools for Visual Studio codebase, then trace how directory traversal handles node_modules. Add coverage for a project containing node_modules and verify that tests there are omitted from discovery and execution.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp, node.js
Domain
testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.