microsoft / microsoft/nodejstools
Clean up Microsoft.NodejsTools.TestAdapter.TestMethodResolver
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 1.8k
- Forks
- 355
- PR merge metrics
- No merged PRs in 30d
Description
Right now, it is never instantiated because Microsoft.NodejsTools.TestAdapter.TestContainerDiscoverer doesn't export itself (except via an interface). However, fixing that problem doesn't resolve the problem because TestMethodResolver.GetCurrentTest unconditionally returns null.
Since we seem to be fine without the functionality now (I think it might be for running a particular test from the editor context menu), deleting the type also seems like a reasonable option.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating Microsoft.NodejsTools.TestAdapter.TestMethodResolver and its references to Microsoft.NodejsTools.TestAdapter.TestContainerDiscoverer. Confirm whether the resolver is unused and whether any editor-context-menu functionality depends on it; done means the dead functionality is removed or made coherent without breaking the test adapter.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- devtools, testing-qa
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100