microsoft / microsoft/node-request-light
NO_PROXY support
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 35
- Forks
- 22
- Avg merge
- 1d 22h
- Merged PRs (30d)
- 2
Description
Overview
The library takes provided proxy url or use system configured proxy in environment variable. However, proxies don't work for internal resources and sending request to e.g. localhost or other internal corporate resources fails, depending on proxy configuration.
To do
- Change reading system proxy settings to include NO_PROXY variable https://github.com/microsoft/node-request-light/blob/main/src/node/main.ts#L268-L272
- If requested resource is in NO_PROXY list, don't use proxy agent
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/node/main.ts around lines 268-272, where system proxy settings are read. Trace how the proxy agent is selected for a requested resource, then verify that resources matching NO_PROXY bypass that agent. Done means NO_PROXY is read and matching internal or localhost requests do not use the proxy.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- nodejs, typescript
- Domain
- networking
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100