microsoft / microsoft/node-native-keymap
Support Electron 32
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 152
- Forks
- 43
- Avg merge
- 19h 38m
- Merged PRs (30d)
- 2
Description
I'm getting the same error for node-native-keymap as the sqlite package was getting when attempting upgrade to Electron 32:
/Users/johnlindquist/.electron-gyp/32.0.1/include/node/v8config.h:13:2: error: "C++20 or later required."
https://github.com/WiseLibs/better-sqlite3/pull/1226
I tried forking and solving it myself, but it's just too far out of my wheelhouse to fully understand the problem. Please help :)
Maybe it's related to this?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the C++20 error while building node-native-keymap against Electron 32, then compare the better-sqlite3 pull request and electron/rebuild issue linked in the report. Review this repository's native build configuration and determine the changes required for a successful Electron 32 build; done means the module builds without the reported v8config.h error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, electron, node.js
- Domain
- build-system, desktop
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100