microsoft / microsoft/node-jsonc-parser

Publish types for setProperty

Open
#20 4 comments 0 reactions 1 assignee View on GitHub

@aeschli is already working on this.

Since May 12, 2019.

feature-request help wanted
Dominant language
TypeScript
Stars
759
Forks
66
Avg merge
5d 10h
Merged PRs (30d)
7

Description

We use the setProperty function by itself. Right now, we use a fork of node-jsonc-parser because the main package doesn't publish types for non-main modules. Would you accept a PR that publishes types for all of the .js files in the npm package?

We use setProperty for the quick action buttons in the JSON settings editors on Sourcegraph, in case anyone's curious about the specific use case:
image

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.