microsoft / microsoft/node-api-dotnet

Refactor embedding API and code to separate assembly

Open
#443 0 comments 1 reaction 1 assignee View on GitHub

@vmoroz is already working on this.

Since Apr 4, 2025.

libnode
Dominant language
C#
Stars
783
Forks
80
PR merge metrics
No merged PRs in 30d

Description

Proposal:

  • Create a new assembly: Microsoft.JavaScript.NodeApi.Embedding and nuget package
  • This assembly / package will have a dependency on the LibNode package for the native embedding runtime
  • Move the public embedding types (NodeEmbedding*) into that assembly / namespace.

Probably there will still need to be some embedding-related code in the core assembly, particularly JSRuntime. I think that's OK.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.