microsoft / microsoft/mu

Improve the readability and reduce brittleness of Variable Services "bucket" logic

Open
#126 2 comments 0 reactions 1 assignee View on GitHub

@makubacki is already working on this.

Since May 10, 2022.

repo:mu_basecore state:backlog type:enhancement
Dominant language
Python
Stars
658
Forks
99
Avg merge
20h 53m
Merged PRs (30d)
1

Description

You can see perhaps the worst offender here:
https://github.com/microsoft/mu_basecore/blob/c4d0d1130454b3e5051bb601c707234e3a91713a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c#L2185

But the idea is to wrap each of these tests in a descriptive macro or function so that it's more readable AND we don't have to change multiple places if we ever change the logic (like adding a new PCD).

Example: WillVarExceedHwErrQuota( VarSize );, or something like that.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.