microsoft / microsoft/mso

Fix unreachable code warnings in Window builds

Open
#29 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
71
Forks
22
PR merge metrics
No merged PRs in 30d

Description

There are a few places in code where the unreachable-code warning has been suppressed to make windows builds work. Remove this suppression, and address the underlying issue.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Start by locating the places where unreachable-code warnings are suppressed for Windows builds, then inspect why the guarded code is unreachable. Done means the suppressions are removed, the underlying issue is addressed, and Windows builds no longer emit those warnings.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
build-system, operating-systems
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.