microsoft / microsoft/msix-packaging
[BUG] cmake_minimum_required should be set to a more reasonable value
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 1.1k
- Forks
- 193
- Avg merge
- 2h 16m
- Merged PRs (30d)
- 2
Description
Project
MSIX SDK
Describe the bug
Commit d375318f01023aa2c2f8d685e804e6c979e10d89 changed cmake_minimum_required to 3.29.0, but I do not see any technical reason for this specific value to have been chosen and it breaks building on systems like Debian stable which is still at 3.25.1, for example.
I can manually change the cmake_minimum_required to 3.25 and build using makeLinux.sh and get working binaries without any issues. The cmake_minimum_required should be the actual minimum required version, not necessarily the version your CI pipeline happens to be using, at least if you intend for others to be able to clone the repo and build it on their systems too.
Yes, it's trivial to just change the value across all the CMakeLists.txt files myself and alternatively there actually is a CMake 3.29 package in Debian stable-backports if it ever really become necessary, but it seems strange to break people's builds that were previously working when it isn't actually necessary.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the CMakeLists.txt files changed by commit d375318f01023aa2c2f8d685e804e6c979e10d89 and compare their minimum version requirements with the build used by makeLinux.sh. Verify whether CMake 3.25.1 builds the MSIX SDK successfully, then ensure the declared minimum reflects the actual requirement across the affected files.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cmake
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100