microsoft / microsoft/msix-packaging

[BUG] OpenSSL Security

Open
#475 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Area-MSIX SDK Feature
Dominant language
C
Stars
1.1k
Forks
193
Avg merge
2h 16m
Merged PRs (30d)
2

Description

In general, X.509 RFCs state that all critical extensions must be validated. There is one Microsoft-specific critical extension (OID 1.3.6.1.4.1.311.21.10 -- Microsoft Application Policies) that is used in Microsoft-issued authenticode certificates and is not validated in the OpenSSL implementation.

Moreover, the implementation uses the flag X509_V_FLAG_IGNORE_CRITICAL when verifying signatures. From the OpenSSL docs:

X509_V_FLAG_IGNORE_CRITICAL disabled critical extension checking. By default any unhandled critical extensions in certificates or (if checked) CRLs results in a fatal error. If this flag is set unhandled critical extensions are ignored. WARNING setting this option for anything other than debugging purposes can be a security risk. Finer control over which extensions are supported can be performed in the verification callback.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with src/msix/PAL/Signature/OpenSSL/SignatureValidator.cpp, especially the verification path around the X509_V_FLAG_IGNORE_CRITICAL use cited in the issue, and review the relevant OpenSSL certificate-verification behavior. Done means critical extensions are not silently ignored and the Microsoft Application Policies extension is handled during authenticode certificate validation.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.