getFeedbackSetExternal not implemented in VerticalConstraintsForSugiyama
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 175
- Forks
- 18
- Avg merge
- 6d 3h
- Merged PRs (30d)
- 4
Description
The docs are quite sparse so not sure if this is bug or just something that is not finished yet or maybe I am doing something wrong with the configuration.
When using VerticalConstraintsForSugiyama the layout code calls getFeedbackSetExternal on the constraints object: https://github.com/microsoft/msagljs/blob/0777c999aad222f0e4e9ea405c0e86aacd3528b9/modules/core/src/layout/layered/layeredLayout.ts#L158
As that call just throws https://github.com/microsoft/msagljs/blob/fe509231409e2cb21693ef1b9e05457761b29627/modules/core/src/layout/layered/verticalConstraintsForSugiyama.ts#L13 it seems like this is not usable at all. Not sure if this is not supposed to be used or there is something else going on here.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in modules/core/src/layout/layered/layeredLayout.ts at the getFeedbackSetExternal call, then inspect modules/core/src/layout/layered/verticalConstraintsForSugiyama.ts where the method throws. Determine whether VerticalConstraintsForSugiyama should support this call or be rejected by the configuration; done means the documented configuration no longer reaches an unimplemented method.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- computer-graphics
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100