CommonJS or AMD dependencies
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 175
- Forks
- 18
- Avg merge
- 6d 3h
- Merged PRs (30d)
- 4
Description
Hello. Just found this library and is awesome. I'm using it in an angular project and I receive the following warnings:
Warning: D:\work\htdocs\hubtalk2-dashboard\node_modules\@msagl\core\dist\layout\layered\layerEdge.js depends on 'typescript-string-operations'. CommonJS or AMD dependencies can cause optimization bailouts.
Warning: D:\work\htdocs\hubtalk2-dashboard\node_modules\@msagl\core\dist\math\geometry\RTree\rectangleNode.js depends on 'stack-typescript'. CommonJS or AMD dependencies can cause optimization bailouts.
Warning: D:\work\htdocs\hubtalk2-dashboard\node_modules\@msagl\core\dist\structs\graph.js depends on 'queue-typescript'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies
I know I can add exceptions for those libraries in angular.json, just wanted to notice this in case you want to move to other libraries that support es6 modules.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the dependency warnings for dist/layout/layered/layerEdge.js, dist/math/geometry/RTree/rectangleNode.js, and dist/structs/graph.js, then inspect the referenced typescript-string-operations, stack-typescript, and queue-typescript packages. Check the Angular CommonJS dependency guidance and angular.json configuration. Done means the library no longer requires those CommonJS or AMD dependency exceptions, if suitable ES6-compatible replacements are identified.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- angular, typescript
- Domain
- build-system, frontend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 28/100