microsoft / microsoft/monaco-editor

[Bug] Accessibility Bug: Broken Focus Management After Closing Search Pop-up Modal

Open
#5,328 2 comments 0 reactions 1 assignee View on GitHub

@rebornix is already working on this.

Since May 19, 2026.

Dominant language
JavaScript
Stars
46.8k
Forks
4.1k
Avg merge
17h 58m
Merged PRs (30d)
1

Description

Image
Reproducible in vscode.dev or in VS Code Desktop?
  • Not reproducible in vscode.dev or VS Code Desktop
Reproducible in the monaco editor playground?
Monaco Editor Playground Link

Issue Description:
There is a critical focus management defect when a user interacts with and exits the search pop-up component. When a keyboard user closes the search pop-up modal, the active focus is entirely lost from the original context and inappropriately dumped into the background code-editor component instead of returning to the invoking element.
Proper keyboard navigation dictates that when temporary content (like a modal or pop-up) is dismissed, focus must be systematically returned to the element that triggered it. Disrupting this flow disorients keyboard-only users and forces them to re-tab through the entire page layout to find their previous location.

Monaco Editor Playground Code

Selector
#IDEInteraction-Q3 > div.ide-container-wrapper > div > div.monaco-editor.no-user-select.showUnused.showDeprecated.vs > div.overflow-guard > div.overlayWidgets > div.editor-widget.find-widget.visible.replaceToggled > div.button.codicon.codicon-widget-close
Source code

Image

Code:

  1. 2. 3. 4.
Reproduction Steps

Steps to Reproduce:
Activate the search feature via keyboard to launch the search pop-up modal.
Interact with the pop-up or navigate directly to the modal's "Close" button using the Tab key.
Activate the "Close" button (via Enter or Spacebar) to dismiss the pop-up.
Observe: Instead of focus resetting cleanly onto the main Search button that originally opened the modal, the focus ring jumps unexpectedly to the code-editor text area.

Actual (Problematic) Behavior

Defect Details:
Impacted UI Components: Search Pop-up Modal / Code Editor
Target Element: "Close" button within the search pop-up
Issue Trigger: Closing or dismissing the search modal
Current Errant Behavior: Keyboard focus snaps straight to the code-editor area upon closing.

Expected Behavior

Expected Behavior:
When modal/pop-up content is removed from the screen in reaction to a user-fired event, focus must be explicitly shifted to the next logical place in the interaction flow. In this specific workflow, closing the search pop-up should seamlessly return the interactive focus to the triggering Search button.

Additional Context

Keyboard focus is lost or misplaced due to user interaction or content update

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.