microsoft / microsoft/monaco-editor
[Bug] Tooltips do not work with webcomponents
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 46.8k
- Forks
- 4.1k
- Avg merge
- 17h 58m
- Merged PRs (30d)
- 1
Description
Reproducible in vscode.dev or in VS Code Desktop?
- Not reproducible in vscode.dev or VS Code Desktop
Reproducible in the monaco editor playground?
- Not reproducible in the monaco editor playground
Monaco Editor Playground Link
No response
Monaco Editor Playground Code
Reproduction Steps
No response
Actual (Problematic) Behavior
in monaco-editor/esm/vs/editor/browser/controller/mouseHandler.js
following line (41) does not work with webcomponents:
if (!this.viewHelper.viewDomNode.contains(e.target)) {
if you change to
if (!this.viewHelper.viewDomNode.contains(e.composedPath()[0])) {
it will work
Expected Behavior
tooltips in webcomponents should work
Additional Context
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at monaco-editor/esm/vs/editor/browser/controller/mouseHandler.js line 41 and inspect how the event target is used for tooltip handling across web component boundaries. Done means tooltips work when Monaco is hosted in a web component; the issue provides no reproduction steps or named test.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend, web-dev
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100