microsoft / microsoft/monaco-editor
[Bug] Import any language now also includes all the features
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 46.8k
- Forks
- 4.1k
- Avg merge
- 17h 58m
- Merged PRs (30d)
- 1
Description
Reproducible in vscode.dev or in VS Code Desktop?
- Not reproducible in vscode.dev or VS Code Desktop
Reproducible in the monaco editor playground?
- Not reproducible in the monaco editor playground
Monaco Editor Playground Link
Monaco Editor Playground Code
Reproduction Steps
After upgrading to v0.55, the bundle size of our apps increased significantly. Once any language is imported, all feature contributions are unintentionally included: https://app.unpkg.com/monaco-editor@0.55.1/files/esm/vs/basic-languages/_.contribution.js
0.54 does not have this issue: https://app.unpkg.com/monaco-editor@0.54.0/files/esm/vs/basic-languages/_.contribution.js
Actual (Problematic) Behavior
No response
Expected Behavior
No response
Additional Context
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the generated vs/basic-languages/_.contribution.js bundle linked in the report and compare it with the v0.54.0 version. Trace the language import path that produces this contribution file and verify that importing one language no longer includes every feature contribution or causes the reported bundle-size increase.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, typescript
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100