microsoft / microsoft/monaco-editor
[Feature Request] Add documentSelector to MonacoLspClient
Open
Nobody has claimed this yet.
feature-request
- Dominant language
- JavaScript
- Stars
- 46.8k
- Forks
- 4.1k
- Avg merge
- 17h 58m
- Merged PRs (30d)
- 1
Description
Context
- This issue is not a bug report. (please use a different template for reporting a bug)
- This issue is not a duplicate of an existing issue. (please use the search to find existing issues)
Description
MonacoLspClient does not support documentSelector(like https://code.visualstudio.com/api/references/vscode-api#DocumentSelector).
This results that all models in monaco editor is synchronized by LSP and sends unnecessary change events to LSP servers.
Monaco Editor Playground Link
N/A
Monaco Editor Playground Code
N/A
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at MonacoLspClient and compare the requested documentSelector behavior with the linked VS Code DocumentSelector reference. Trace how Monaco models are synchronized and determine how unrelated models should be excluded from LSP change events. Done means documentSelector is supported and models outside the selection are no longer synchronized.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100