microsoft / microsoft/monaco-editor

[Bug] Monaco editor used inline styling that violates Content Security Policy for a web application

Open
#4,927 8 comments 10 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
46.8k
Forks
4.1k
Avg merge
17h 58m
Merged PRs (30d)
1

Description

Reproducible in vscode.dev or in VS Code Desktop?
  • Not reproducible in vscode.dev or VS Code Desktop
Reproducible in the monaco editor playground?
Monaco Editor Playground Link

No response

Monaco Editor Playground Code

Reproduction Steps

Prerequisites:
Node.js LTS should be available

Unzip the attached monaco-editor-demo.zip, navigate to the 'monaco-editor-demo' folder using command prompt

cd monaco-editor-demo
npm install
npm install monaco-editor
npm run preview

Access browser link generated to see the violation in browser console(png image attached)

Browser snapshot
Image

Sample code
monaco-editor-demo.zip

Actual (Problematic) Behavior

The CSP configuration is done in dist\index.html file, in line 5

<meta http-equiv="Content-Security-Policy" content="default-src 'self'; script-src 'self'; script-src-elem 'self'; script-src-attr 'self'; font-src 'self'; connect-src 'self'; img-src 'self'; style-src 'self'; form-action '*'; frame-src 'self'; worker-src 'self'; frame-ancestors 'self' "/>

Image

We are using Monaco editor in our enterprise application. To support EU-CRA, we are trying to turn on Content Security Policy(CSP) in our application. However, we are getting many inline styling CSP violations coming from monaco editor code. The sample application attached is demonstrating the issue in a standalone web application.

Expected Behavior

No response

Additional Context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running the attached monaco-editor-demo.zip with Node.js LTS using the commands in the issue, then inspect the browser console and dist\index.html line 5. Trace the reported inline-style violations to the Monaco integration; done should mean a maintainer-approved resolution for the stated CSP, though the issue does not define expected behavior or name a source file.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, typescript
Domain
frontend, security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.