microsoft / microsoft/monaco-editor
[Bug] `setSelections` from `codeEditorWidget` doens't allow `IRange` objects
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 46.8k
- Forks
- 4.1k
- Avg merge
- 17h 58m
- Merged PRs (30d)
- 1
Description
Reproducible in vscode.dev or in VS Code Desktop?
- Not reproducible in vscode.dev or VS Code Desktop
Reproducible in the monaco editor playground?
- Not reproducible in the monaco editor playground
Monaco Editor Playground Link
Monaco Editor Playground Code
const value = /* set from `myEditor.getModel()`: */ `function hello() {
alert('Hello world!');
}`;
// Hover on each property to see its docs!
const myEditor = monaco.editor.create(document.getElementById("container"), {
value,
language: "javascript",
automaticLayout: true,
});
myEditor.setSelection(new monaco.Range(1, 1, 1, 5))
const selections = [new monaco.Range(1, 1, 1, 10)]
myEditor.setSelections(selections)
Reproduction Steps
setSelectionwithRangeobject,setSelectionswithRangeobjects array throws error
Actual (Problematic) Behavior
myEditor.setSelection works with Range, but setSelections doesn't work with array of Ranges, throws error Invalid arguments. I think it is a little inconsistent.
Expected Behavior
setSelections to work both with selections and with ranges.
Additional Context
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Monaco Editor Playground reproduction and compare codeEditorWidget's setSelection and setSelections behavior using the supplied v0.52.2 example. Trace the argument handling for the two entry points; done means setSelections accepts an array of monaco.Range objects without the Invalid arguments error while continuing to support selections.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100