microsoft / microsoft/monaco-editor

[Bug] `setSelections` from `codeEditorWidget` doens't allow `IRange` objects

Open
#4,867 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
46.8k
Forks
4.1k
Avg merge
17h 58m
Merged PRs (30d)
1

Description

Reproducible in vscode.dev or in VS Code Desktop?
  • Not reproducible in vscode.dev or VS Code Desktop
Reproducible in the monaco editor playground?
Monaco Editor Playground Link

https://microsoft.github.io/monaco-editor/playground.html?source=v0.52.2#XQAAAAINAgAAAAAAAABBqQkHQ5NjdMjwa-jY7SIQ9S7DNlzs5W-mwj0fe1ZCDRFc9ws9XQE0SJE1jc2VKxhaLFIw9vEWSxW3yscw0bsmqAEiAKctgAboa7AaZZDHLgrLqPRv_fRv2RyIokydlTdTYccsu6v6jDrc8jQ8ulrCVzjWBVWZVl-YrARXWjHX0-tquUNesdygYRbQM1JUnAtHpBvKZs9BqKWrhBtx8AKci-FcKka370IseIUS4jh1xLN3vO9tVYrhvcDTPK1M1aTHEjwgfXku0y66bEkQ1NYJNuvNWrg-wDjbR_t6NJefGB_IpORsJxMG6nKbV-lGx86TPPqNjYey3BLB_G0f4DhvZ0SAZlaX7kbxFQmQKFyaKQhUfnvoWqCACSwvLy4OgqsDS4h6-ee_viYpmUKX0B6N8POR2qcqGNM7HflcfUke7M-cxCAcU8q_BqY3sLYDOXCRqmob0zQ33lAwLf-GOKIg

Monaco Editor Playground Code
const value = /* set from `myEditor.getModel()`: */ `function hello() {
	alert('Hello world!');
}`;

// Hover on each property to see its docs!
const myEditor = monaco.editor.create(document.getElementById("container"), {
	value,
	language: "javascript",
	automaticLayout: true,
});

myEditor.setSelection(new monaco.Range(1, 1, 1, 5))

const selections = [new monaco.Range(1, 1, 1, 10)]

myEditor.setSelections(selections)
Reproduction Steps
  • setSelection with Range object,
  • setSelections with Range objects array throws error
Actual (Problematic) Behavior

myEditor.setSelection works with Range, but setSelections doesn't work with array of Ranges, throws error Invalid arguments. I think it is a little inconsistent.

Expected Behavior

setSelections to work both with selections and with ranges.

Additional Context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Monaco Editor Playground reproduction and compare codeEditorWidget's setSelection and setSelections behavior using the supplied v0.52.2 example. Trace the argument handling for the two entry points; done means setSelections accepts an array of monaco.Range objects without the Invalid arguments error while continuing to support selections.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.