microsoft / microsoft/monaco-editor
[Bug] symbols from JS extra libs can be renamed
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 46.8k
- Forks
- 4.1k
- Avg merge
- 17h 58m
- Merged PRs (30d)
- 1
Description
Reproducible in vscode.dev or in VS Code Desktop?
- Not reproducible in vscode.dev or VS Code Desktop
Reproducible in the monaco editor playground?
- Not reproducible in the monaco editor playground
Monaco Editor Playground Link
Configure Javascript Defaults example
Monaco Editor Playground Code
Reproduction Steps
- In the code editor, put the cursor on
next(line 5). - Hit the F2 key to rename it and add a character for instance.
Actual (Problematic) Behavior
The rename is accepted but only partially (it's renamed in the model only).
Expected Behavior
The rename should be blocked (i.e. a no-op) like for the standard libs.
Additional Context
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue points to the Configure Javascript Defaults example in the Monaco Editor Playground; start there and inspect rename behavior for symbols from JavaScript extra libs. Done means F2 rename is a no-op for those symbols, matching standard-library behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend, tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100