microsoft / microsoft/monaco-editor
[Bug] applyEdits nonsupport undoed
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 46.8k
- Forks
- 4.1k
- Avg merge
- 17h 58m
- Merged PRs (30d)
- 1
Description
Reproducible in vscode.dev or in VS Code Desktop?
- Not reproducible in vscode.dev or VS Code Desktop
Reproducible in the monaco editor playground?
- Not reproducible in the monaco editor playground
Monaco Editor Playground Link
version: v0.52.2
description: monaco editor playground error
Monaco Editor Playground Code
const value = /* set from `myEditor.getModel()`: */ `function hello() {
alert('Hello world!');
}`;
// Hover on each property to see its docs!
const myEditor = monaco.editor.create(document.getElementById("container"), {
value,
language: "javascript",
automaticLayout: true,
});
myEditor.addAction({
id: "dys.a.c",
label: "test",
keybindings: [KeyMod.CtrlCmd | KeyCode.KeyS],
run() {
// myEditor.pushUndoStop();
myEditor.getModel()?.applyEdits([{ text: "312", range: new Range(1, 1, 10, 10) }], true)
// myEditor.popUndoStop()
}
})
Reproduction Steps
ctrl + s
Actual (Problematic) Behavior
Not after changing the code unoded
Expected Behavior
The code should be withdrawn from the previous
Additional Context
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Monaco Editor playground reproduction and the provided TypeScript snippet, focusing on the model's applyEdits call and its interaction with undo. Confirm the behavior after pressing Ctrl+S, then verify that the applied edit can be withdrawn as described by the expected behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100