microsoft / microsoft/monaco-editor

Luminosity ratio of the 'use device code' text is less than required ratio 4.5:1 present under 'Run script' tab.

Open
#4,758 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

accessibility bug
Dominant language
JavaScript
Stars
46.8k
Forks
4.1k
Avg merge
17h 58m
Merged PRs (30d)
1

Description

Reproducible in vscode.dev or in VS Code Desktop?
  • Not reproducible in vscode.dev or VS Code Desktop
Reproducible in the monaco editor playground?
Monaco Editor Playground Link

Monaco Editor

Monaco Editor Playground Code
const value = /* set from `myEditor.getModel()`: */ `function hello() {
	az login --use-device-code
}`;

// Hover on each property to see its docs!
const myEditor = monaco.editor.create(document.getElementById("container"), {
	value: "az login --use-device-code",
	language: "shell",
	automaticLayout: true,
});
<div id="container" style="height: 100%"></div>
Reproduction Steps
  1. Open link: Monaco Editor
  2. Monaco Editor page gets displayed.
  3. Open Accessibility insights for windows-color contrast tool.
  4. Select Foreground and Background color of the 'use device code' text using color picker.
  5. Verify whether Luminosity ratio of the "use device code" text present under 'Run script' tab which is less than required ratio of 4.5:1 or not.
Actual (Problematic) Behavior

Luminosity ratio of the "use device code" text present under 'Run script' tab is 3.996:1 which is less than required ratio of 4.5:1 in Windows.

Image

Expected Behavior

Luminosity ratio of placeholder "use device code" text should be greater than or equal to 4.5:1 in Windows.

Additional Context

Test Environment:
OS: Windows 11 Version 24H2(OS Build 26120.1542)
Browser: Edge Browser 129.0.2792.31
Tools Used: Accessibility insights for windows-color contrast tool.

User Impact:
Low vision users will not be able to read and access the information provided if luminosity ratio for text is not meeting required ratio of 4.5:1.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Monaco Editor Playground entry point and reproduce the Run script tab example from the linked playground code. Inspect the styling for the “use device code” text, adjust it so the Windows contrast ratio is at least 4.5:1, and verify the result with an accessibility contrast tool.

Written by the indexing model from the issue text.

Assessment

Tech stack
shell, typescript
Domain
accessibility, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.