microsoft / microsoft/monaco-editor
[Bug] Inline suggestion interaction with empty autocomplete broke after 0.41
Open
Nobody has claimed this yet.
bug
suggest
- Dominant language
- JavaScript
- Stars
- 46.8k
- Forks
- 4.1k
- Avg merge
- 17h 58m
- Merged PRs (30d)
- 1
Description
Reproducible in vscode.dev or in VS Code Desktop?
- Not reproducible in vscode.dev or VS Code Desktop
Reproducible in the monaco editor playground?
- Not reproducible in the monaco editor playground
Monaco Editor Playground Link
Monaco Editor Playground Code
monaco.languages.registerInlineCompletionsProvider("json", {
provideInlineCompletions: function (model, position, context, token) {
console.log('Provide new completion', position, context, token)
return {items: [
{
insertText: 'chenfan'
},
{
insertText: 'hello world'
}
]};
},
freeInlineCompletions: function (completions) {
console.log(completions);
},
});
monaco.languages.registerCompletionItemProvider('json', {
provideCompletionItems: () => {
return {
suggestions: [
]
};
}
});
monaco.editor.create(document.getElementById("container"), {
value: '',
language: "json",
});
Reproduction Steps
See the video
Actual (Problematic) Behavior
Cannot accept the inline suggestion when an empty suggest list shows
Expected Behavior
Can accept inline suggest if the auto compelte suggest list is not empty
Additional Context
https://github.com/user-attachments/assets/362d8322-93df-426a-806d-84da8632dc0c
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Monaco Editor Playground configuration and reproduce the interaction using the registered inline completions and completion-item providers. Trace how an empty autocomplete suggestion list affects inline suggestion acceptance, then verify that the inline suggestion can still be accepted when the list is empty.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100