microsoft / microsoft/monaco-editor
[Bug] v0.51.0 breaks for browser based imports
Open
Nobody has claimed this yet.
blocked
bug
editor-core
- Dominant language
- JavaScript
- Stars
- 46.8k
- Forks
- 4.1k
- Avg merge
- 17h 58m
- Merged PRs (30d)
- 1
Description
Reproducible in vscode.dev or in VS Code Desktop?
- Not reproducible in vscode.dev or VS Code Desktop
Reproducible in the monaco editor playground?
- Not reproducible in the monaco editor playground
Monaco Editor Playground Link
No response
Monaco Editor Playground Code
No response
Reproduction Steps
upgrade from v0.50.0 to v0.51.0
Actual (Problematic) Behavior
v0.50.0 was including the script: editor/editor.main.nls.js.
this silently got removed in v0.51.0 without getting mentioned inside the release log:
https://github.com/microsoft/monaco-editor/commit/e52ff427290808dff6809b3f77866ae7a62a119b
after removing the script as well inside the Neo.mjs env, i encountered several errors and warnings:
Expected Behavior
there should be no undocumented breaking changes in minor versions.
Additional Context
cross-reference ticket:
https://github.com/neomjs/neo/issues/5822
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.