microsoft / microsoft/monaco-editor

[Bug] ThirdPartyNotices.txt licensing error for Web Background Synchronization

Open
#4,639 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug license
Dominant language
JavaScript
Stars
46.8k
Forks
4.1k
Avg merge
17h 58m
Merged PRs (30d)
1

Description

Reproducible in vscode.dev or in VS Code Desktop?
  • Not reproducible in vscode.dev or VS Code Desktop
Reproducible in the monaco editor playground?
Monaco Editor Playground Link

No response

Monaco Editor Playground Code

No response

Reproduction Steps

No response

Actual (Problematic) Behavior

The ThirdPartyNotices.txt file states that "Web Background Synchronization Specification" is used, but the license text below says "As a condition of the copyright grant, you must include an attribution to the Specification in any derivative work you make based on the Specification. That attribution must include, at minimum, the Specification name and version number."

This requirement is not met in this derivative work since it doesn't mention the spec version number so it looks like Monaco could be technically in breach of the license.

Expected Behavior

It should be very easy to add the spec version into ThirdPartyNotices.txt to comply with the license's attribution requirement OR just remove this whole section from the file if it's not really used (I couldn't find any reference to it in the codebase)

Additional Context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading ThirdPartyNotices.txt and searching the codebase for references to the Web Background Synchronization Specification. Confirm whether it is used, then update the notice with the required specification version or remove the section if it is unused. Done means the notice accurately reflects the dependency and its attribution requirements.

Written by the indexing model from the issue text.

Assessment

Domain
documentation
Issue type
Documentation
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.