microsoft / microsoft/monaco-editor
[Feature Request] Make close icon for the details suggestions view button
Open
Nobody has claimed this yet.
feature-request
- Dominant language
- JavaScript
- Stars
- 46.8k
- Forks
- 4.1k
- Avg merge
- 17h 58m
- Merged PRs (30d)
- 1
Description
Context
- This issue is not a bug report. (please use a different template for reporting a bug)
- This issue is not a duplicate of an existing issue. (please use the search to find existing issues)
Description
It will be good for the accessibility purposes to make the close icon in the suggestion details view the button component or add to the span element the following attributes: tabIndex, role="button" and handle specific keyboard events
Monaco Editor Playground Link
https://microsoft.github.io/monaco-editor/playground.html?source=v0.50.0#XQAAAAJkAQAAAAAAAABBqQkHQ5NjdMjwa-jY7SIQ9S7DNlzs5W-mwj0fe1ZCDRFc9ws9XQE0SJE1jc2VKxhaLFIw9vEWSxW3yscwzaJoe_1uhs0-3YGTBOsVJ4S4FwfCDQb5-2uUHXTVAefbVSd9IzaZ_vv9VR9KugsKimARHSWlrTPOQHROITHxmAetfeRrm3VHdSe7_Etv6WpgzlH4vE8EOEFHk0dQY6yu0Ds0_YA-Qy1YvkOxpjeN3ENG9FMT3UbTx9FNNSa3RT9OWNMggceF38-aRLFLo16vZ77QMpUk2KuxLaKKfQxocxJpi0i7KBTZk1QY3_-G-5g3aWhJuwAleDxvTI-B5dEP98tU0NPFgTrf9yss11Cwkhfd-WPgfMFYYB1B7lwVn__3S7zu
Monaco Editor Playground Code
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the supplied Monaco Editor Playground link and inspect the suggestions details view, locating the close icon and how it is rendered. The work is done when the close control is keyboard accessible and its activation behavior is handled consistently with a button.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- accessibility, frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100