microsoft / microsoft/monaco-editor

[Bug] toolbar background of inline completion is broken

Open
#4,493 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
46.8k
Forks
4.1k
Avg merge
17h 58m
Merged PRs (30d)
1

Description

Reproducible in vscode.dev or in VS Code Desktop?
  • Not reproducible in vscode.dev or VS Code Desktop
Reproducible in the monaco editor playground?
Monaco Editor Playground Link

https://microsoft.github.io/monaco-editor/playground.html?source=v0.44.0#XQAAAAK1AgAAAAAAAABBqQkHQ5NjdMjwa-jY7SIQ9S7DNlzs5W-mwj0fe1ZCDRFc9ws9XQE0SJE1jc2VKxhaLFIw9vEWSxW3yscw2QLL3dbD0yTm9PBkbpAuszLxat513xnts26zU4KLcG-5K2Qwa3pW3MVb8Lero-zqqdj9hXQDbTxtd7kclK98Z7Doycw-0OYHYSlOAlrwcDfOAGHNu4loJGX-ccU_92Fkb7LXIUCtFHoZtaOfioVk1p9QEyGWHGAmJLKPgFRC8yXVIwZplFp1k0yBRRE9K9KWGGxzH216wbZrSyKbSEIcrPqvXy4wGZPcCXl0ZyI0e6a65n1RonQHK0CglErG0xTGof33BuaBqUoJXHlXkzdUQiSzqzAHiJ3liGcLiLbZ27_XvqX5gEhIa1Uy7ZHgknqjcEBnu8M-MVyuNwnGWHO90iP5q0Z5_KCpga5NUurgtA7B4gnaDupUmToS1qEeotTD6RHWMg80z7HR7n82P9nmYfR__98jfQA

Monaco Editor Playground Code
monaco.languages.registerInlineCompletionsProvider("json", {
	provideInlineCompletions: function (model, position, context, token) {
        console.log('new sugg')
		return {items: [
                    {
                        insertText: 'hello world'
                    }
                ]};
	},
    handleItemDidShow: function() {
        console.log('show')
    },
	freeInlineCompletions: function (completions) {
		console.log('free');
	},
    handlePartialAccept: function() {
        console.log('partial');
    }
});

monaco.editor.create(document.getElementById("container"), {
	value: '',
	language: "json",
});
Reproduction Steps
  • Hover on the inline completion
  • Click ... in the toolbar
  • the background of more actions is broken
Actual (Problematic) Behavior

No background & always show toolbar doesn't work

Expected Behavior
  1. Background become normal for the more actions;
  2. Always Show Toolbar works as expected
Additional Context
Screenshot 2024-05-02 at 4 46 54 PM

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked Monaco Editor Playground reproduction and its TypeScript inline-completions provider, then reproduce the hover, toolbar, and More Actions interaction. Done means the More Actions background appears normally and the Always Show Toolbar option works as expected.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.