microsoft / microsoft/monaco-editor

[Bug] d.classList is undefined

Open
#4,465 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
46.8k
Forks
4.1k
Avg merge
17h 58m
Merged PRs (30d)
1

Description

Reproducible in vscode.dev or in VS Code Desktop?
  • Not reproducible in vscode.dev or VS Code Desktop
Reproducible in the monaco editor playground?
Monaco Editor Playground Link

No response

Monaco Editor Playground Code

No response

Reproduction Steps

No response

Actual (Problematic) Behavior

No response

Expected Behavior

No response

Additional Context

I cannot repro in stack trace or even our prod, just adding another datapoint here. Monaco version is 0.43 and I see something same happens to 0.44 before:
https://github.com/microsoft/monaco-editor/issues/4296

Stack trace if useful:

'd.classList is undefined'
at _j (monaco-editor/esm/vs/editor/contrib/hover/browser/hover.js:154:67)
at _onEditorMouseMove (node_modules/monaco-editor/esm/vs/editor/contrib/hover/browser/hover.js:69:68)
at value (node_modules/monaco-editor/esm/vs/base/common/event.js:864:21)
at _deliver (node_modules/monaco-editor/esm/vs/base/common/event.js:875:17)
at _deliverQueue (node_modules/monaco-editor/esm/vs/base/common/event.js:899:17)
at fire (node_modules/monaco-editor/esm/vs/editor/browser/widget/codeEditorWidget.js:1522:14)
at fire (node_modules/monaco-editor/esm/vs/editor/browser/widget/codeEditorWidget.js:1411:67)
at call (node_modules/monaco-editor/esm/vs/editor/browser/view/viewUserInputEvents.js:34:72)
at emitMouseMove (node_modules/monaco-editor/esm/vs/editor/browser/view/viewController.js:243:29)
at emitMouseMove (node_modules/monaco-editor/esm/vs/editor/browser/controller/mouseHandler.js:190:28)
at _onMouseMove (node_modules/monaco-editor/esm/vs/editor/browser/controller/mouseHandler.js:29:17)
at callback (node_modules/monaco-editor/esm/vs/editor/browser/editorDom.js:129:69)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with monaco-editor/esm/vs/editor/contrib/hover/browser/hover.js at line 154 and trace the hover mouse-move path shown in the stack trace through the related event files. Reproduce the reported d.classList failure before determining a fix; done means the hover path no longer throws when that condition occurs.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.