microsoft / microsoft/monaco-editor
[Bug] DiffEditor with glyphMargin: false, still renders glyphMargin when rendered side by side.
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 46.8k
- Forks
- 4.1k
- Avg merge
- 17h 58m
- Merged PRs (30d)
- 1
Description
Reproducible in vscode.dev or in VS Code Desktop?
- Not reproducible in vscode.dev or VS Code Desktop
Reproducible in the monaco editor playground?
- Not reproducible in the monaco editor playground
Monaco Editor Playground Link
Monaco Editor Playground Code
var originalModel = monaco.editor.createModel(
"This line is removed on the right.\njust some text\nabcd\nefgh\nSome more text",
"text/plain"
);
var modifiedModel = monaco.editor.createModel(
"just some text\nabcz\nzzzzefgh\nSome more text\nThis line is removed on the left.",
"text/plain"
);
var diffEditor = monaco.editor.createDiffEditor(
document.getElementById("container"),
{
// Renders without glyph margin
// renderSideBySide: false,
// glyphMargin: false,
// Still shows glyphMargin
renderSideBySide: true,
useInlineViewWhenSpaceIsLimited: false,
glyphMargin: false,
}
);
diffEditor.setModel({
original: originalModel,
modified: modifiedModel,
});
Reproduction Steps
Set these options and observe that the glyph margin is still shown.
renderSideBySide: true,
useInlineViewWhenSpaceIsLimited: false,
glyphMargin: false,
Actual (Problematic) Behavior
Glyph margin is turned off, but still renders when the diff editor is in side by side mode.
Expected Behavior
I would expect, regardless of whether it is rendered in side by side or not, that if glyphMargin is set to false, then glyphMargin should not be shown,
Additional Context
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked Monaco Editor Playground reproduction and the createDiffEditor options shown in the issue, comparing side-by-side and inline rendering. Trace how glyphMargin is applied when renderSideBySide is true; done means glyphMargin remains hidden in side-by-side mode when set to false, without changing the inline behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100